Re: Potential ABI breakage in upcoming minor releases

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Aleksander Alekseev <aleksander@timescale.com>

Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Christoph Berg <myon@debian.org>, Noah Misch <noah@leadboat.com>, Pavan Deolasee <pavan.deolasee@gmail.com>

Date: 2024-11-14T20:49:02Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Undo unintentional ABI break in struct ResultRelInfo.
- ee33d58471de 16.6 landed
- 6bfacd368bb4 17.2 landed
- 17db248f318f 15.10 landed
- 099e711b77b8 14.15 landed
For inplace update durability, make heap_update() callers wait.
- 51ff46de29f6 16.5 cited
Fix btmarkpos/btrestrpos array key wraparound bug.
- 3fa81b62e09b 16.1 cited
Fix calculation of which GENERATED columns need to be updated.
- 8cd190e13a22 14.7 cited

Aleksander Alekseev <aleksander@timescale.com> writes:
> The third case is the following:

> ```
> extern TSDLLEXPORT ResultRelInfo *
> ts_catalog_open_indexes(Relation heapRel)
> {
>     ResultRelInfo *resultRelInfo;

>     resultRelInfo = makeNode(ResultRelInfo);
>     resultRelInfo->ri_RangeTableIndex = 0; /* dummy */
>     resultRelInfo->ri_RelationDesc = heapRel;
>     resultRelInfo->ri_TrigDesc = NULL; /* we don't fire triggers */

>     ExecOpenIndices(resultRelInfo, false);

>     return resultRelInfo;
> }
> ```

I'd call that a bug in timescale.  It has no business assuming that
it can skip InitResultRelInfo.

			regards, tom lane