Re: Review: listagg aggregate

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Peter Eisentraut <peter_e@gmx.net>, Scott Bailey <artacus@comcast.net>, "pgsql-hackers@postgresql.org Hackers" <pgsql-hackers@postgresql.org>
Date: 2010-01-25T13:57:10Z
Lists: pgsql-hackers
Pavel Stehule <pavel.stehule@gmail.com> writes:
> 2010/1/25 Peter Eisentraut <peter_e@gmx.net>:
>> xmlagg -> concatenates values to form xml datum
>> array_agg -> concatenates values to form array datum
>> ??? -> concatenates values to form string datum
>> 
>> So it's pretty clear that listagg does not fit into this scheme.

> when you define list as text domain, then this the name is correct.

IOW, if you define away the problem then there's no problem?

I agree that "list" is a terrible choice of name here.  "string_agg"
seemed reasonable and in keeping with the standardized "array_agg".

			regards, tom lane