Re: build gcc warning

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Pavel Stehule <pavel.stehule@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-12-27T23:10:39Z
Lists: pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2022-12-27 01:55:06 -0500, Tom Lane wrote:
>> A couple of buildfarm animals are warning about that too ... but
>> only a couple.

> I'm a bit confused by gcc getting confused here - the condition for
> sub_rteperminfos getting initialized and used are the same. Most of the time
> the maybe-uninitialized logic seems to be better than this.

Apparently the key phrase there is "most of the time" ;-).

I see that we've had an equally "unnecessary" initialization of the
sibling variable sub_rtable for a long time, so the problem's been
there for some people before.  I made it initialize sub_rteperminfos
the same way.

			regards, tom lane



Commits

  1. Suppress uninitialized-variable warning from a61b1f748.