Horton

Re: Supporting Windows SChannel as OpenSSL replacement

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Heikki Linnakangas <hlinnakangas@vmware.com>
Cc: Jeff Janes <jeff.janes@gmail.com>, Andreas Karlsson <andreas@proxel.se>, Martijn van Oosterhout <kleptog@svana.org>, Magnus Hagander <magnus@hagander.net>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2014-08-15T20:57:23Z
Lists: pgsql-hackers 
Heikki Linnakangas <hlinnakangas@vmware.com> writes:
> On 08/15/2014 08:16 PM, Jeff Janes wrote:
>> Should the ereport DEBUG2 be inside the "#ifdef USE_SSL"?

> Yeah.

> I've been thinking though, perhaps we should always have the ssl_in_use, 
> peer_cn and peer_cert_valid members in the Port struct. If not compiled 
> with USE_SSL, they would just always be false/NULL. Then we wouldn't 
> need #ifdefs around all the places that check hose fields either.

+1.  This would also make it less risky for add-on code to touch the Port
struct.

			regards, tom lane