Re: Do we still need gen_node_support.pl's nodetag ABI stability check?
Daniel Gustafsson <daniel@yesql.se>
From: Daniel Gustafsson <daniel@yesql.se>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
pgsql-hackers@lists.postgresql.org
Date: 2026-04-15T19:47:05Z
Lists: pgsql-hackers
> On 15 Apr 2026, at 21:30, Peter Eisentraut <peter@eisentraut.org> wrote: > > On 14.04.26 07:04, Tom Lane wrote: >> On the one hand, there's much to be said for belt-and-suspenders-too >> safety checks. On the other hand, updating gen_node_support.pl is >> an extra manual step while creating a branch, so it's easy to forget >> or get wrong. It's also not very clear why this particular sort >> of ABI break in a stable branch is any worse than other hazards. > > This might still be helpful because it checks during local builds and doesn't rely on the buildfarm. But does it actually give a good enough answer to be relied upon when passing the local check can fail the buildfarm check? -- Daniel Gustafsson
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Remove gen_node_support.pl's ad-hoc ABI stability check.
- 1cd3cd372ae4 19 (unreleased) landed
-
Add defenses against unexpected changes in the NodeTag enum list.
- eea9fa9b250f 16.0 cited