Horton

Re: CPU costs of random_zipfian in pgbench

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, Georgios Kokolatos <gkokolatos@pm.me>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2019-04-01T21:59:04Z
Lists: pgsql-hackers 
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> On 2019-Apr-01, Tom Lane wrote:
>> Seems reasonable.  Pushed with minor documentation editing.

> Ah, so we now we can get rid of the TState * being passed around
> separately for expression execution, too?

I didn't really look for follow-on simplifications, but if there
are some to be made, great.  (That would be further evidence for
my opinion that this feature was overcomplicated ...)

			regards, tom lane

Commits

  1. Remove now-unnecessary thread pointer arguments in pgbench.

  2. Restrict pgbench's zipfian parameter to ensure good performance.