Re: [PATCH] pg_dump: lock tables in batches

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Gilles Darold <gilles@migops.com>

Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Fabrízio de Royes Mello <fabriziomello@gmail.com>, Aleksander Alekseev <aleksander@timescale.com>, Andres Freund <andres@anarazel.de>

Date: 2023-01-03T23:00:37Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

During pg_dump startup, acquire table locks in batches.
- 5f53b42cfd05 16.0 landed

Gilles Darold <gilles@migops.com> writes:
> As it seems to have a consensus to apply this patch I will change the 
> commitfest status to ready for committers.

Yeah.  I still have a nagging worry about why I didn't do this already,
but without evidence I can't fairly block the patch.  Hence, pushed.

I did cut the LOCK TABLE query length limit from 1MB to 100K, because
I doubt there is any measurable performance difference, and I'm a
little worried about overstressing smaller servers.

			regards, tom lane