Re: Potential ABI breakage in upcoming minor releases

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Noah Misch <noah@leadboat.com>

Cc: Christoph Berg <myon@debian.org>, Pavan Deolasee <pavan.deolasee@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2024-11-14T19:30:33Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Undo unintentional ABI break in struct ResultRelInfo.
- ee33d58471de 16.6 landed
- 6bfacd368bb4 17.2 landed
- 17db248f318f 15.10 landed
- 099e711b77b8 14.15 landed
For inplace update durability, make heap_update() callers wait.
- 51ff46de29f6 16.5 cited
Fix btmarkpos/btrestrpos array key wraparound bug.
- 3fa81b62e09b 16.1 cited
Fix calculation of which GENERATED columns need to be updated.
- 8cd190e13a22 14.7 cited

Noah Misch <noah@leadboat.com> writes:
> It's not immediately to clear to me why this would crash in a non-asserts
> build.  palloc issues a 512-byte chunk for sizeof(ResultRelInfo)==368 on v16,
> so I expect no actual writing past the end of the chunk.

I'm confused too.  The allocation should be big enough.  The other
hazard would be failing to initialize the field, but if the extension
uses InitResultRelInfo then that's taken care of.

			regards, tom lane