Uncommented GUC in postgresql.conf.sample

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>

To: Postgres hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-11-14T14:06:44Z

Lists: pgsql-hackers

Attachments

v1-0001-Make-sure-all-GUCs-in-.conf.sample-are-commented-.patch (application/octet-stream) patch v1-0001

When looking at the nearby suggestion to add deprecation comment for md5 in the
.conf.sample, I happened to notice that autovacuum_worker_slots isn't commented
out it the sample file.

AFAIK all GUCs in the sample file should be set to their defaults and left
commented out.  The attached does that for autovacuum_worker_slots and adds a
trivial test to test_misc to catch it (and modifies the existing test which
would've caught it). Or is there a case for leaving uncommented?

--
Daniel Gustafsson

Commits

Add test for postgresql.conf.sample line syntax
- 446568c22207 19 (unreleased) landed
Comment out autovacuum_worker_slots in postgresql.conf.sample.
- c73213992471 18.2 landed
- 478c4814a052 19 (unreleased) landed