Horton

Re: Add comment explaining why queryid is int64 in pg_stat_statements

Shaik Mohammad Mujeeb <mujeeb.sk@zohocorp.com>

View thread
From: Shaik Mohammad Mujeeb <mujeeb.sk@zohocorp.com>
To: "dgrowleyml" <dgrowleyml@gmail.com>
Cc: "Michael Paquier" <michael@paquier.xyz>, "Nathan Bossart" <nathandbossart@gmail.com>, "Peter Eisentraut" <peter@eisentraut.org>, "Lukas Fittl" <lukas@fittl.com>, "ilyaevdokimov" <ilya.evdokimov@tantorlabs.com>, "pgsql-hackers" <pgsql-hackers@postgresql.org>, "mujeebskdev" <mujeeb.sk.dev@gmail.com>, "pgsql-hackers" <pgsql-hackers@lists.postgresql.org>, "Alvaro Herrera" <alvherre@kurilemu.de>, "Tomas Vondra" <tomas@vondra.me>
Date: 2025-05-30T11:34:10Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Change internal plan ID type from uint64 to int64

  2. Change internal queryid type from uint64 to int64

  3. pg_stat_statements: Widen query IDs from 32 bits to 64 bits.

Thanks for making the appropriate changes, David.

Now everything make sense. :)











---- On Fri, 30 May 2025 16:39:23 +0530 David Rowley <dgrowleyml@gmail.com> wrote ---



On Fri, 30 May 2025 at 11:51, David Rowley < mailto:dgrowleyml@gmail.com > wrote: 
> 
> On Fri, 30 May 2025 at 11:35, Michael Paquier < mailto:michael@paquier.xyz > wrote: 
> > Thanks, Nathan.  Let's proceed with the change then.  David, would you 
> > prefer handling the patch you have written by yourself for the query 
> > ID part? 
> 
> Yes. I'll look at that again shortly. 
 
Now done. 
 
David