Re: fix psql \conninfo & \connect when using hostaddr
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Arthur Zakirov <a.zakirov@postgrespro.ru>,
Pavel Stehule <pavel.stehule@gmail.com>,
Fabien COELHO <coelho@cri.ensmp.fr>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
Robert Haas <robertmhaas@gmail.com>
Date: 2018-11-08T15:00:32Z
Lists: pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> On 2018-Nov-08, Arthur Zakirov wrote:
>> I just meant something like this (additional "{", "}" braces):
> We omit braces when there's an individual statement. (We do add the
> braces when we have a comment atop the individual statement, though, to
> avoid pgindent from doing a stupid thing.)
For the record --- I just checked, and pgindent will not mess up code like
if (condition)
/* comment here */
do_something();
at least not as long as the comment is short enough for one line.
(If it's a multiline comment, it seems to want to put a blank line
in front of it, which is not very nice in this context.)
Visually, however, I think this is better off with braces because
it *looks* like a multi-line if-block. The braces also make it
clear that your intent was not, say,
while (some-mutable-condition)
/* skip */ ;
do_something_else();
regards, tom lane
Commits
-
Tweak libpq's PQhost, PQhostaddr, and psql's \connect
- 313f56ce2d1b 12.0 landed
-
psql: Show IP address in \conninfo
- 6e5f8d489acc 12.0 landed