Horton

Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Mankirat Singh <mankiratsingh1315@gmail.com>
Cc: "David E. Wheeler" <david@justatheory.com>, nathandbossart@gmail.com, pg@bowt.ie, andrew@dunslane.net, pgsql-hackers@lists.postgresql.org
Date: 2025-10-18T15:14:49Z
Lists: pgsql-hackers 
Mankirat Singh <mankiratsingh1315@gmail.com> writes:
> But if we want a much clearer way based on symbol names, we could use a
> standard per branch suppression file, which the abidiff tool directly
> supports for this purpose[1].

I am strongly against relying on suppression files.  I think that
is a very imprecise technology, and it is certainly harder to use
than the "choose a blessed reference point" approach.

			regards, tom lane

Commits

  1. Add commit 24f6c1bd4 to v17 .abi-compliance-history.

  2. Add .abi-compliance-history to back-branches.

  3. Add reminder to create .abi-compliance-history.

  4. Update .abi-compliance-history file.

  5. Add .abi-compliance-history to v18 branch.

  6. Fix thinko in commit 7d129ba54.

  7. Fix lookups in pg_{clear,restore}_{attribute,relation}_stats().

  8. Add defenses against unexpected changes in the NodeTag enum list.