Re: COPY FROM WHEN condition
Tomas Vondra <tomas.vondra@2ndquadrant.com>
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Surafel Temesgen <surafel3000@gmail.com>
Cc: Adam Berlin <berlin.ab@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2018-11-30T13:43:25Z
Lists: pgsql-hackers
On 11/30/18 2:00 PM, Surafel Temesgen wrote: > > > On Thu, Nov 29, 2018 at 2:17 AM Tomas Vondra > <tomas.vondra@2ndquadrant.com <mailto:tomas.vondra@2ndquadrant.com>> wrote: > > (c) allow VOLATILE functions in the FILTER clause, but change the > behavior to make the behavior sane > > Did changing the behavior means getting new snapshot before evaluating > a tuple to ensure the function sees results of any previously executed > queries or there are other mechanism that can make the behavior sane? > I think it should be enough just to switch to CIM_SINGLE and increment the command counter after each inserted row. > Which leaves us with (b) and (c). Clearly, (b) is simpler to implement, > because it (c) needs to do the detection too, and then some additional > stuff. I'm not sure how much more complex (c) is, compared to (b). > > The attache patch implement option b prohibit VOLATILE functions but i > am open to change OK. I'll take a look. regards -- Tomas Vondra http://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Remove unused struct member, enforce multi_insert callback presence.
- 57a7a3adfe4e 12.0 landed
-
Separate per-batch and per-tuple memory contexts in COPY
- 36a1281f86c0 12.0 landed
-
Fix handling of volatile expressions in COPY FROM ... WHERE
- 4a8283d0ec5a 12.0 landed
-
Allow COPY FROM to filter data using WHERE conditions
- 31f3817402da 12.0 landed
-
Remove obsolete netbsd dynloader code
- b68ff3ea672c 12.0 cited