Re: [bug fix] Savepoint-related statements terminates connection
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Simon Riggs <simon@2ndquadrant.com>
Cc: Michael Paquier <michael.paquier@gmail.com>,
"Tsunakawa,
Takayuki" <tsunakawa.takay@jp.fujitsu.com>,
Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>,
"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2017-09-01T16:40:42Z
Lists: pgsql-hackers
Simon Riggs <simon@2ndquadrant.com> writes: > On 1 September 2017 at 15:19, Tom Lane <tgl@sss.pgh.pa.us> wrote: >> This patch makes me itch. Why is it correct for these three checks, >> and only these three checks out of the couple dozen uses of isTopLevel >> in standard_ProcessUtility, to instead do something else? > No problem, it was a quick fix, not a deep one. My thought is that what we need to do is find a way for isTopLevel to be false if we're processing a multi-command string. It looks like exec_simple_query is already doing the right thing in terms of what it tells PortalRun; why is that not propagating down to ProcessUtility? regards, tom lane
Commits
-
Improve documentation about behavior of multi-statement Query messages.
- b976499480bd 11.0 landed
-
Fix handling of savepoint commands within multi-statement Query strings.
- 6eb52da3948d 11.0 landed
-
Arrange for PreventTransactionChain to reject commands submitted as part
- 4f896dac17f7 8.3.0 cited