Horton

Re: [HACKERS] A weird bit in pg_upgrade/exec.c

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: a.akenteva@postgrespro.ru
Cc: pgsql-hackers@postgresql.org
Date: 2017-11-16T16:20:02Z
Lists: pgsql-hackers 
a.akenteva@postgrespro.ru writes:
> I see this bug is now fixed in pg_upgrade/exec.c => check_bin_dir().

> There's another bit exactly like that in check_data_dir() though.

Oh, so there is ... and looking around, that seems to have been
copied-and-pasted out of check_cluster_versions(), without any
thought for the fact that those calls were thereby made redundant.

Fix pushed, thanks for noticing!

			regards, tom lane

Commits

  1. Fix bogus logic for checking data dirs' versions within pg_upgrade.

  2. Fix bogus logic for checking executables' versions within pg_upgrade.