Horton

Thread

Commits

  1. Update documentation for snowball update

  2. Update snowball

  1. snowball release

    Peter Eisentraut <peter.eisentraut@2ndquadrant.com> — 2020-05-22T12:40:44Z

    Snowball has made a release!  With a tag!

I have prepared a patch to update PostgreSQL's copy.  (not attached 
here, 566230 bytes, but see 
https://github.com/petere/postgresql/commit/52a6133b58c77ada4210a96e5155cbe4da5e5583)

Since we last updated our copy from their commit date 2019-06-24 and the 
release is from 2019-10-02, the changes are pretty small and mostly 
reformatting.  But there are three new stemmers: Basque, Catalan, Hindi.

I think some consideration could be given for including this into PG13. 
Otherwise, I'll park it for PG14.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

  2. Re: snowball release

    Tom Lane <tgl@sss.pgh.pa.us> — 2020-05-22T14:11:17Z

    Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> Snowball has made a release!  With a tag!
> I have prepared a patch to update PostgreSQL's copy.

Yeah, this was on my to-do list as well.  Thanks for doing it.

> I think some consideration could be given for including this into PG13. 
> Otherwise, I'll park it for PG14.

Meh, I think v14 at this point.  It looks more like new features
than bug fixes.

			regards, tom lane

  3. Re: snowball release

    Oleg Bartunov <obartunov@postgrespro.ru> — 2020-05-23T08:21:46Z

    On Fri, May 22, 2020 at 5:11 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:

> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> > Snowball has made a release!  With a tag!
> > I have prepared a patch to update PostgreSQL's copy.
>
> Yeah, this was on my to-do list as well.  Thanks for doing it.
>

+1


>
> > I think some consideration could be given for including this into PG13.
> > Otherwise, I'll park it for PG14.
>
> Meh, I think v14 at this point.  It looks more like new features
> than bug fixes.
>
>
I would vote for including these new languages. There is no risk to let
people try and test them.


>                         regards, tom lane
>
>
>

-- 
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

  4. Re: snowball release

    Peter Eisentraut <peter.eisentraut@2ndquadrant.com> — 2020-06-08T06:21:02Z

    On 2020-05-22 14:40, Peter Eisentraut wrote:
> Snowball has made a release!  With a tag!
> 
> I have prepared a patch to update PostgreSQL's copy.  (not attached
> here, 566230 bytes, but see
> https://github.com/petere/postgresql/commit/52a6133b58c77ada4210a96e5155cbe4da5e5583)
> 
> Since we last updated our copy from their commit date 2019-06-24 and the
> release is from 2019-10-02, the changes are pretty small and mostly
> reformatting.  But there are three new stemmers: Basque, Catalan, Hindi.
> 
> I think some consideration could be given for including this into PG13.
> Otherwise, I'll park it for PG14.

committed to master

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

  5. Re: snowball release

    Tom Lane <tgl@sss.pgh.pa.us> — 2020-06-08T14:33:05Z

    Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 2020-05-22 14:40, Peter Eisentraut wrote:
>> I think some consideration could be given for including this into PG13.
>> Otherwise, I'll park it for PG14.

> committed to master

Hm, I don't see any documentation change in that commit --- don't
we have (at least) a list of the stemmers somewhere in the SGML docs?

			regards, tom lane

  6. Re: snowball release

    Daniel Gustafsson <daniel@yesql.se> — 2020-06-08T14:47:01Z

    > On 8 Jun 2020, at 16:33, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> 
> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
>> On 2020-05-22 14:40, Peter Eisentraut wrote:
>>> I think some consideration could be given for including this into PG13.
>>> Otherwise, I'll park it for PG14.
> 
>> committed to master
> 
> Hm, I don't see any documentation change in that commit --- don't
> we have (at least) a list of the stemmers somewhere in the SGML docs?

IIRC we refer to the Snowball site, and only have a list in the \dFd output,
but that can be argued to be an example and not expected to be updated to
match.  Perhaps we should though?

cheers ./daniel

  7. Re: snowball release

    Tom Lane <tgl@sss.pgh.pa.us> — 2020-06-08T15:19:25Z

    Daniel Gustafsson <daniel@yesql.se> writes:
> On 8 Jun 2020, at 16:33, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Hm, I don't see any documentation change in that commit --- don't
>> we have (at least) a list of the stemmers somewhere in the SGML docs?

> IIRC we refer to the Snowball site, and only have a list in the \dFd output,
> but that can be argued to be an example and not expected to be updated to
> match.  Perhaps we should though?

Looking in the commit logs, our past updates 7b925e127 and
fd582317e just updated that \dFd sample.  So I guess that's the
minimum expectation.  Maybe we should think about having a more
formal list in the actual Snowball section (12.6.6)?

			regards, tom lane

  8. Re: snowball release

    Peter Eisentraut <peter.eisentraut@2ndquadrant.com> — 2020-06-08T20:48:01Z

    On 2020-06-08 17:19, Tom Lane wrote:
> Daniel Gustafsson <daniel@yesql.se> writes:
>> On 8 Jun 2020, at 16:33, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> Hm, I don't see any documentation change in that commit --- don't
>>> we have (at least) a list of the stemmers somewhere in the SGML docs?
> 
>> IIRC we refer to the Snowball site, and only have a list in the \dFd output,
>> but that can be argued to be an example and not expected to be updated to
>> match.  Perhaps we should though?
> 
> Looking in the commit logs, our past updates 7b925e127 and
> fd582317e just updated that \dFd sample.  So I guess that's the
> minimum expectation.

done

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services