Horton

Re: BUG #15572: Misleading message reported by "Drop function operation" on DB with functions having same name

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <david.rowley@2ndquadrant.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Ash M <makmarath@hotmail.com>, pgsql-bugs@lists.postgresql.org
Date: 2019-01-09T00:36:06Z
Lists: pgsql-bugs, pgsql-hackers 
David Rowley <david.rowley@2ndquadrant.com> writes:
> Why can't we just remove the !noError check in the location where the
> error is raised?

I don't like that a bit --- the point of noError is to prevent throwing
errors, and it doesn't seem like it should be LookupFuncName's business
to decide it's smarter than its callers.  Maybe we need another flag
argument?

			regards, tom lane

Commits

  1. Improve error reporting for DROP FUNCTION/PROCEDURE/AGGREGATE/ROUTINE.