Horton

Re: Preventing abort() and exit() calls in libpq

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>, Michael Paquier <michael@paquier.xyz>
Cc: Jacob Champion <pchampion@vmware.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Daniel Gustafsson <daniel@yesql.se>
Date: 2021-06-30T17:24:26Z
Lists: pgsql-hackers 
On 26.06.21 23:29, Tom Lane wrote:
> After some thought I propose that what we really want is to prevent
> any calls of abort() or exit() from inside libpq.  Attached is a
> draft patch to do that.

Could we set this rule up a little bit differently so that it is only 
run when the library is built.

Right now, make world on a built tree makes 17 calls to this "nm" line, 
and make check-world calls it 81 times.  I think once would be enough. ;-)

Commits

  1. Further restrict the scope of no-exit()-in-libpq test.

  2. Improve build-time check that libpq doesn't call exit().

  3. Fix portability fallout from commit dc227eb82.

  4. Add a build-time check that libpq doesn't call exit() or abort().