Re: improvements in Unicode tables generation code
Peter Eisentraut <peter.eisentraut@enterprisedb.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Heikki Linnakangas <hlinnaka@iki.fi>,
pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2021-07-20T11:57:16Z
Lists: pgsql-hackers
Attachments
- 0001-Make-Unicode-makefile-parallel-safe.patch (text/plain) patch 0001
On 23.06.21 10:55, Peter Eisentraut wrote: >>> v1-0001-Make-Unicode-makefile-more-parallel-safe.patch >>> >>> The makefile rule that calls UCS_to_most.pl was written incorrectly for >>> parallel make. The script writes all output files in one go, but the >>> rule as written would call the command once for each output file in >>> parallel. >> >> This could use a comment. At a quick glance, I don't understand what >> all the $(wordlist ...) magic does. >> >> Perhaps we should change the script or Makefile so that it doesn't >> create all the maps in one go? > > I agree, either comment it better or just write one file at a time. I'll > take another look at that. Here is a patch that does it one file (pair) at a time. The other rules besides UCS_to_most.pl actually had the same problem, since they produce two output files, so running in parallel called each script twice. In this patch, all of that is heavily refactored and works correctly now. Note that UCS_to_most.pl already accepted a command-line argument to specify which encoding to work with.
Commits
-
Make Unicode makefile parallel-safe
- e75272719579 15.0 landed
-
Remove some whitespace in generated C output
- 344dedfd1c24 15.0 landed
-
Make UCS_to_most.pl process encodings in sorted order
- 4d56115f721f 15.0 landed