Horton

Re: BUG #16631: postgres_fdw tries to insert into generated columns

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Etsuro Fujita <etsuro.fujita@gmail.com>, dacherny@gmail.com, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Date: 2021-07-07T15:54:19Z
Lists: pgsql-bugs 
Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> On 07.07.21 09:20, Etsuro Fujita wrote:
>> * Modified nodeModifyTable.c and copyfrom.c so that they don't compute
>> generated columns for FDWs anymore.

> I don't agree with that change.  What is the point of declaring a 
> generated column on a foreign table if you ignore it?  Then you might as 
> well prohibit declaring such columns in the first place.

Maybe what we need here is some documentation clarifying exactly what
the point of a generated column on a foreign table actually *is*.
When would you do it, and what relationship if any has it got to the
generation status of the underlying remote column?

			regards, tom lane

Commits

  1. postgres_fdw: Fix issues with generated columns in foreign tables.