Re: Why does pgindent's README say to download typedefs.list from the buildfarm?
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org
Date: 2024-05-15T20:50:04Z
Lists: pgsql-hackers
Attachments
- pgindent_readme_v4.patch (text/x-diff) patch v4
Nathan Bossart <nathandbossart@gmail.com> writes: > On Wed, May 15, 2024 at 04:07:18PM -0400, Robert Haas wrote: >> How's this? > I compared this with my v1, and the only bit of information there that I > see missing in v3 is that validation step 4 only applies in the > once-per-cycle run (or if you forget to pgindent before committing a > patch). This might be why I was struggling to untangle the two types of > pgindent runs in my attempt. Perhaps it's worth adding a note to that step > about when it is required. Oh ... another problem is that the VALIDATION steps really apply to both kinds of indent runs, but it's not clear to me that that's obvious in v3. Maybe the steps should be rearranged to be (1) base case, (2) VALIDATION, (3) ONCE PER CYCLE. At this point my OCD got the better of me and I did a little additional wordsmithing. How about the attached? regards, tom lane
Commits
-
Sync typedefs.list with buildfarm, for real this time.
- 70353e463cd3 17.0 landed
-
Remove unused typedefs
- be5942aee7a0 17.0 landed
-
Remove enum WaitEventExtension
- 110eb4aefbad 17.0 landed
-
Add pgindent typedefs file to CVS.
- 16040575a044 9.0.0 cited