Horton

Re: BUG #16037: Assertion fails in varbit_out

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Date: 2019-10-04T05:52:07Z
Lists: pgsql-bugs 
Andres Freund <andres@anarazel.de> writes:
> On 2019-10-04 01:34:48 -0400, Tom Lane wrote:
>> D'oh ... bitshiftright() needs to do the zero-pad-fixup in both
>> code paths.  Will fix it tomorrow.

> Does that suggest we shouldn't make the asserts active in the branches <
> 12?

No, it just means the previous patch was an incomplete fix.  The
whole point of the asserts was to flush out cases where we weren't
padding correctly, and they just did that :-)

(Besides which, we discourage people from running with asserts on
in production, so I don't quite see what your concern is.)

			regards, tom lane

Commits

  1. Fix bitshiftright()'s zero-padding some more.