Horton

Re: ALTER TEXT SEARCH DICTIONARY tab completion

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Georgios Kokolatos <gkokolatos@pm.me>
Cc: pgsql-hackers@lists.postgresql.org, Jeff Janes <jeff.janes@gmail.com>
Date: 2020-03-07T22:00:50Z
Lists: pgsql-hackers

Attachments

Georgios Kokolatos <gkokolatos@pm.me> writes:
> One minor nitpick I feel I should add is that for completeness and
> balance the equivalent `CREATE TEXT SEARCH DICTIONARY` should
> get the same treatment.

> Maybe something along the lines of:
> -       else if (Matches("CREATE", "TEXT", "SEARCH", "CONFIGURATION", MatchAny))
> +       else if (Matches("CREATE", "TEXT", "SEARCH", "DICTIONARY|CONFIGURATION", MatchAny))

Agreed; actually all four CREATE TEXT SEARCH commands could do that.
I pushed it as attached.

			regards, tom lane

Commits

  1. Tab completion: offer parens as appropriate in CREATE/ALTER TEXT SEARCH.