Horton

Re: pg_verifybackup: TAR format backup verification

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Amul Sul <sulamul@gmail.com>, Sravan Kumar <sravanvcybage@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2024-10-01T14:48:08Z
Lists: pgsql-hackers 
Robert Haas <robertmhaas@gmail.com> writes:
> Here is an attempt at cleaning this up. I'm far from convinced that
> it's fully correct; my local compiler (clang version 15.0.7) doesn't
> seem fussed about conflating size_t with uint64, not even with -Wall
> -Werror. I don't suppose you have a fussier compiler locally that you
> can use to test this?

Sure, I can try it on mamba's host.  It's slow though ...

> Respectfully, if you'd just said in your first email about this "I
> understand that you were trying to be consistent with a format string
> somewhere else, but I don't think that's a good reason to do it this
> way, so please use %llu and insert a cast," I would have just said
> "fine, no problem" and I wouldn't have been irritated at all.

I apologize for rubbing you the wrong way on this.  It was not my
intent.  (But, in fact, I had not realized you copied that code
from somewhere else.)

			regards, tom lane

Commits

  1. Adjust json_manifest_per_file_callback API in one more place.

  2. File size in a backup manifest should use uint64, not size_t.

  3. Fix some pg_verifybackup issues reported by Coverity.

  4. pg_verifybackup: Move some declarations to new pg_verifybackup.h

  5. pg_verifybackup: Move skip_checksums into verifier_context.

  6. Improve file header comments for astramer code.

  7. Move astreamer (except astreamer_inject) to fe_utils.

  8. Move recovery injector astreamer to a separate header file.

  9. Rename bbstreamer to astreamer.