Re: scram-sha-256 broken with FIPS and OpenSSL 1.0.2
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Daniel Gustafsson <daniel@yesql.se>, Heikki Linnakangas <hlinnaka@iki.fi>,
Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-09-25T04:27:03Z
Lists: pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes: > On Fri, Sep 25, 2020 at 12:19:44PM +0900, Michael Paquier wrote: >> Even if we'd try to force our internal implementation of SHA256 on >> already-released branches instead of the one of OpenSSL, this would be >> an ABI break for compiled modules expected to work on this released >> branch as OpenSSL's internal SHA structures don't exactly match with >> our own implementation (think just about sizeof() or such). > Well, we could as well add one extra SHA API layer pointing to the EVP > structures and APIs with new names, leaving the original ones in > place, and then have SCRAM use the new ones, but I'd rather not go > down that road for the back-branches. Given the tiny number of complaints to date, it seems sufficient to me to deal with this in HEAD. regards, tom lane
Commits
-
Change SHA2 implementation based on OpenSSL to use EVP digest routines
- 4f48a6fbe2b2 14.0 landed
- e21cbb4b893b 14.0 landed
-
Move SHA2 routines to a new generic API layer for crypto hashes
- 87ae9691d253 14.0 landed
-
Use OpenSSL EVP API for symmetric encryption in pgcrypto.
- 5ff4a67f63fd 10.0 cited