Horton

Re: race condition in pg_class

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
Cc: Smolkin Grigory <smallkeen@gmail.com>, pgsql-hackers@postgresql.org
Date: 2025-09-11T19:34:47Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Replace tests of ALTER DATABASE RESET TABLESPACE.

  2. meson: Flush stdout in testwrap

  3. Fix catcache invalidation of a list entry that's being built

  4. Stop reading uninitialized memory in heap_inplace_lock().

  5. Fix use of uninitialized value in previous commit.

  6. Back-patch "Refactor code in tablecmds.c to check and process tablespace moves"

  7. Fix data loss at inplace update after heap_update().

  8. For inplace update durability, make heap_update() callers wait.

  9. Warn if LOCKTAG_TUPLE is held at commit, under debug_assertions.

  10. Don't lose partitioned table reltuples=0 after relhassubclass=f.

  11. Fix new assertion for MERGE view_name ... DO NOTHING.

  12. Remove configuration-dependent output from new inplace-inval test.

  13. AccessExclusiveLock new relations just after assigning the OID.

  14. Cope with inplace update making catcache stale during TOAST fetch.

  15. Expand comments and add an assertion in nodeModifyTable.c.

  16. Improve test coverage for changes to inplace-updated catalogs.

  17. Lock before setting relhassubclass on RELKIND_PARTITIONED_INDEX.

  18. Lock owned sequences during ALTER TABLE SET { LOGGED | UNLOGGED }.

  19. Make TAP todo_start effects the same under Meson and prove_check.

  20. Add an injection_points isolation test suite.

  21. Add wait event type "InjectionPoint", a custom type like "Extension".

  22. Create waitfuncs.c for pg_isolation_test_session_is_blocked().

  23. Rework planning and execution of UPDATE and DELETE.

Noah Misch <noah@leadboat.com> writes:
> On Thu, Sep 11, 2025 at 12:36:04PM -0400, Tom Lane wrote:
>> It emerges that the "ALTER DATABASE regression_utf8 RESET TABLESPACE"
>> command is a complete no-op [1].  I am guessing that that was not the
>> behavior you had in mind, and am wondering if we are losing any test
>> coverage thereby.  Did you have a specific reason for manipulating the
>> TABLESPACE property and not some random GUC setting?

> I have no specific notes or memories about that RESET TABLESPACE, but I likely
> wanted "SET TABLESPACE pg_default".  RESET TABLESPACE may still have the
> effect of loading a catcache entry, as a later comment says:
> ...
> I'm inclined to change it as
> attached.  This doesn't reduce database.sql test coverage of dbcommands.c or
> catcache.c, so I'll bet it doesn't lose anything vs. the original database.sql
> commit.  Some check-tests runs showed it adding database.sql coverage of
> catcache.c:1908-1911 and catcache.c:1983-1984, so that's a bonus.

Thanks, that looks sane.

> Do you plan to back-patch that?  That should dictate whether I back-patch the
> test change.

That change will convert some commands that are currently no-ops into
errors, which doesn't seem like a great thing to do in minor releases.
However ... it might still be okay to cram it into v18.  Do you have
an opinion about that?

			regards, tom lane