Re: getopt() and strdup()
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Phil Sorber <phil@omniti.com>
Cc: Bruce Momjian <bruce@momjian.us>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2012-10-13T19:14:09Z
Lists: pgsql-hackers
Phil Sorber <phil@omniti.com> writes: > On Wed, Oct 10, 2012 at 7:54 PM, Bruce Momjian <bruce@momjian.us> wrote: >> Also, do we want to centralize the definition of pg_strdup() in /port, >> or leave each module to define it on its own? > +1 for a centralized definition. The difficulty with a centralized definition is that it's not clear that the error path is or should be *exactly* the same for all these usages. I see at least six variants right now. While some are gratuitous, some of them are tied into local conventions of each program. regards, tom lane