Re: Make message strings in fe-connect.c consistent

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>
To: Gurjeet Singh <gurjeet@singh.im>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2023-04-21T08:34:41Z
Lists: pgsql-hackers
> On 21 Apr 2023, at 07:02, Gurjeet Singh <gurjeet@singh.im> wrote:
> On Thu, Apr 20, 2023 at 9:31 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:

>>>> libpq_append_conn_error(conn, "invalid require_auth method: \"%s\"",
>>>> method);
>> 
>> Yup, this one did not get the memo.

I've pushed this, with the change to use the common "invalid %s value" format
that we use for all other libpq options.  This makes this string make use of
already existing translations and makes error reporting consistent.

> That explains why I could not find any translation for this error message.

The feature is new in master so any translations for it are yet to be merged
from the translation repo.

--
Daniel Gustafsson




Commits

  1. Make libpq error messages consistent for translation

  2. Support connection load balancing in libpq