Re: Inadequate parallel-safety check for SubPlans

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
Cc: robertmhaas@gmail.com, pgsql-hackers@postgresql.org
Date: 2017-04-16T16:00:58Z
Lists: pgsql-hackers
Noah Misch <noah@leadboat.com> writes:
> On Wed, Apr 12, 2017 at 02:41:09PM -0400, Tom Lane wrote:
>> This is 100% wrong.  It's failing to recurse into the subexpressions of
>> the SubPlan, which could very easily include parallel-unsafe function
>> calls.  Example:

> The above-described topic is currently a PostgreSQL 10 open item.  Robert,
> since you committed the patch believed to have created it, you own this open
> item.  If some other commit is more relevant or if this does not belong as a
> v10 open item, please let us know.

FYI, I have this on my to-look-at list, and expect to fix it before Robert
returns from vacation.

			regards, tom lane


Commits

  1. Fix testing of parallel-safety of SubPlans.