Horton

Re: Assert failure when rechecking an exclusion constraint

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
Cc: pgsql-hackers@postgresql.org, Jeff Davis <pgsql@j-davis.com>
Date: 2011-06-05T15:51:48Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add an Assert that indexam.c isn't used on an index awaiting reindexing.

Noah Misch <noah@leadboat.com> writes:
> On Sat, Jun 04, 2011 at 05:49:31PM -0400, Tom Lane wrote:
>> So in short, I'm thinking move lines 1760-1772 (in HEAD) of index.c to
>> the end of index_build(), then insert a ResetReindexProcessing() call in
>> front of them; or maybe only do ResetReindexProcessing there if we
>> actually do call IndexCheckExclusion.

> Sounds reasonable.  Need to remove the index from pendingReindexedIndexes, not
> just call ResetReindexProcessing().

[ looks again... ]  Uh, right.  I was thinking that the pending list was
just "pending" and not "in progress" indexes.  I wonder if we should
rejigger things so that that's actually true, ie, remove an index's OID
from the pending list when we mark it as the current one?

> Also, wouldn't that specific construction
> make the catalog updates fail due to running in the table owner's security
> context?

AFAIR there's no security checks happening below this level.

			regards, tom lane