Re: Safer and faster get_attstatsslot()

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Simon Riggs <simon@2ndquadrant.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2017-05-11T17:20:57Z
Lists: pgsql-hackers
Simon Riggs <simon@2ndquadrant.com> writes:
> On 11 May 2017 at 17:41, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> ...because code that worked fine for Peter and me failed
>> erratically in the buildfarm.

> I think its always a little bit too exciting for me also.

> I suggest we have a commit tree and a main tree, with automatic
> copying from commit -> main either
> 1. 24 hours after commit
> 2. or earlier if we have a full set of green results from people
> running the full suite on the commit tree

Meh.  We don't really need that in normal development, and for security
patches there's still a problem: we don't want to wait around 24 hours
after the code is public.

			regards, tom lane


Commits

  1. Remove no-longer-needed fields of Hash plan nodes.

  2. Redesign get_attstatsslot()/free_attstatsslot() for more safety and speed.