Thread

1. bugfix for cursor arguments in named notation

   Yeb Havinga <yebhavinga@gmail.com> — 2012-04-04T09:47:43Z

   Using a cursor argument name equal to another plpgsql variable results 
   in the error:
   cursor .. has no argument named ""
   
   The attached patch fixes that.
   
   Instead of solving the issue like is done in the patch, another way 
   would be to expose internal_yylex() so that could be used instead of 
   yylex() by read_cursor_args when reading the argument name, and would 
   always return the argument name in yylval.str.
   
   -- 
   Yeb Havinga
   http://www.mgrid.net/
   Mastering Medical Data
   
   

2. Re: bugfix for cursor arguments in named notation

   Tom Lane <tgl@sss.pgh.pa.us> — 2012-04-04T15:10:32Z

   Yeb Havinga <yebhavinga@gmail.com> writes:
   > Using a cursor argument name equal to another plpgsql variable results 
   > in the error:
   > cursor .. has no argument named ""
   
   > The attached patch fixes that.
   
   > Instead of solving the issue like is done in the patch, another way 
   > would be to expose internal_yylex() so that could be used instead of 
   > yylex() by read_cursor_args when reading the argument name, and would 
   > always return the argument name in yylval.str.
   
   I think a better way would be to temporarily set
   plpgsql_IdentifierLookup to IDENTIFIER_LOOKUP_DECLARE, so as to suppress
   variable name lookup in the first place.  The patch as you have it seems
   to me to make too many assumptions about what name lookup might produce.
   
   			regards, tom lane
   
   

3. Re: bugfix for cursor arguments in named notation

   Yeb Havinga <yebhavinga@gmail.com> — 2012-04-05T08:05:33Z

   On 2012-04-04 17:10, Tom Lane wrote:
   > Yeb Havinga<yebhavinga@gmail.com>  writes:
   >> Using a cursor argument name equal to another plpgsql variable results
   >> in the error:
   >> cursor .. has no argument named ""
   > I think a better way would be to temporarily set
   > plpgsql_IdentifierLookup to IDENTIFIER_LOOKUP_DECLARE, so as to suppress
   > variable name lookup in the first place.  The patch as you have it seems
   > to me to make too many assumptions about what name lookup might produce.
   >
   >
   
   Thank you for looking at it. Attached is a patch that implements your 
   suggestion.
   
   regards,
   Yeb
   
   

4. Re: bugfix for cursor arguments in named notation

   Tom Lane <tgl@sss.pgh.pa.us> — 2012-04-05T14:01:57Z

   Yeb Havinga <yebhavinga@gmail.com> writes:
   > On 2012-04-04 17:10, Tom Lane wrote:
   >> I think a better way would be to temporarily set
   >> plpgsql_IdentifierLookup to IDENTIFIER_LOOKUP_DECLARE,
   
   > Thank you for looking at it. Attached is a patch that implements your 
   > suggestion.
   
   Oh, sorry, I assumed you'd seen that I committed a fix like that last
   night.
   
   			regards, tom lane