Re: 15beta1 tab completion of extension versions

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jeff Janes <jeff.janes@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-06-18T23:49:28Z
Lists: pgsql-hackers
Jeff Janes <jeff.janes@gmail.com> writes:
> Extension version strings need to be quoted.  Either double or single
> quotes will work.  In released psql clients, tab completion offers double
> quoted suggestions:
> But commit 02b8048ba5 broke that, it now offers unquoted version strings
> which if used as offered then lead to syntax errors.

Ooops.

> The code change seems to have been intentional, but I don't think the
> behavior change was intended.

Given the comments about it, I'm sure I tested the behavior somewhere
along the line --- but I must not have done so with the final logic
of _complete_from_query.

> Putting pg_catalog.quote_ident back
> into Query_for_list_of_available_extension_versions* fixes it, but might
> not be the best way to fix it.

Yeah, that seems like the appropriate fix.  Done, thanks for the report!

			regards, tom lane



Commits

  1. Simplify tab completion of extension versions, redux.

  2. Simplify tab completion of extension versions.

  3. Fix busted tab completion of extension versions.

  4. psql: improve tab-complete's handling of variant SQL names.