Re: 15beta1 tab completion of extension versions
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jeff Janes <jeff.janes@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-06-18T23:49:28Z
Lists: pgsql-hackers
Jeff Janes <jeff.janes@gmail.com> writes: > Extension version strings need to be quoted. Either double or single > quotes will work. In released psql clients, tab completion offers double > quoted suggestions: > But commit 02b8048ba5 broke that, it now offers unquoted version strings > which if used as offered then lead to syntax errors. Ooops. > The code change seems to have been intentional, but I don't think the > behavior change was intended. Given the comments about it, I'm sure I tested the behavior somewhere along the line --- but I must not have done so with the final logic of _complete_from_query. > Putting pg_catalog.quote_ident back > into Query_for_list_of_available_extension_versions* fixes it, but might > not be the best way to fix it. Yeah, that seems like the appropriate fix. Done, thanks for the report! regards, tom lane
Commits
-
Simplify tab completion of extension versions, redux.
- 22a67fdd5d27 16.0 landed
- 207fc033bd9f 15.0 landed
-
Simplify tab completion of extension versions.
- 662dbe2c8657 15.0 landed
-
Fix busted tab completion of extension versions.
- 9cd43f6cbd8b 15.0 landed
-
psql: improve tab-complete's handling of variant SQL names.
- 02b8048ba5dc 15.0 cited