Re: Reducing pg_ctl's reaction time
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>, Jeff Janes <jeff.janes@gmail.com>,
Michael Paquier <michael.paquier@gmail.com>,
PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2017-06-28T20:02:03Z
Lists: pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes: > Tom Lane wrote: >> So when I removed the miscadmin.h include, I found out that pg_ctl is >> also relying on PG_BACKEND_VERSIONSTR from that file. >> >> There are at least three things we could do here: >> >> 1. Give this up as not worth this much trouble. >> >> 2. Move PG_BACKEND_VERSIONSTR into pg_config.h to go along with the >> other version-related macros. > pg_config.h sounds like a decent enough solution. It's a bit strange > this hasn't come up before, given that that symbol is used more in > frontend environ than backend. Right at the moment, what I've done is to stick it into port.h beside the declaration of find_other_exec, since the existing uses are all as parameters of find_other_exec[_or_die]. But maybe that's a bit too expedient. regards, tom lane
Commits
-
Change pg_ctl to detect server-ready by watching status in postmaster.pid.
- f13ea95f9e47 10.0 landed
-
Reduce pg_ctl's reaction time when waiting for postmaster start/stop.
- c61559ec3a41 10.0 landed