Horton

Re: ENOSPC FailedAssertion("!(RefCountErrors == 0)"

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Michael Paquier <michael@paquier.xyz>, Justin Pryzby <pryzby@telsasoft.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2018-07-18T00:55:05Z
Lists: pgsql-hackers 
Robert Haas <robertmhaas@gmail.com> writes:
> On Tue, Jul 17, 2018 at 8:01 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Any objections?  Anyone want to do further review?

> LGTM.  I think this is an improvement.  However, it seems like it
> might be a good idea for ResourceOwnerRememberBuffer and
> ResourceOwnerForgetBuffer to Assert(buffer != NULL), so that if
> somebody messes up it will trip an assertion rather than just seg
> faulting.

Uh, what?  There are only a few callers of those, and they'd all have
crashed already if they were somehow dealing with an invalid buffer.

			regards, tom lane

Commits

  1. Use a ResourceOwner to track buffer pins in all cases.