Re: [Bug Fix] ECPG: could not use set xxx to default statement
Michael Meskes <meskes@postgresql.org>
From: Michael Meskes <meskes@postgresql.org>
To: Tom Lane <tgl@sss.pgh.pa.us>, Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: "Higuchi, Daisuke" <higuchi.daisuke@jp.fujitsu.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2019-02-23T09:35:06Z
Lists: pgsql-hackers
> Not seeing any motion on this, here's a draft patch to make these > scripts complain about missing semicolons. Against the current > gram.y (which contains 2 such errors, as Michael noted) you > get output like Thanks Tom for looking into this. Are we agreed then that we want gram.y to have semicolons? > '/usr/bin/perl' ./parse.pl . < ../../../backend/parser/gram.y > > preproc.y > unterminated rule at ./parse.pl line 370, <> line 1469. > make: *** [preproc.y] Error 255 > make: *** Deleting file `preproc.y' > > That's not *super* friendly, but it does give you the right line > number > to look at in gram.y. We could adjust the script (and the Makefile) > further so that the message would cite the gram.y filename, but I'm > not > sure if it's worth the trouble. Thoughts? IMO it's not worth it. We all know where the grammar is and that the ecpg tools only parse that one file. Why putting effort into writing it down too? Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql) dot Org Jabber: michael at xmpp dot meskes dot org VfL Borussia! Força Barça! SF 49ers! Use Debian GNU/Linux, PostgreSQL
Commits
-
Fix ecpg bugs caused by missing semicolons in the backend grammar.
- 53c2bb78db9f 9.4.22 landed
- 3a682a21b7f9 9.5.17 landed
- de94ed89d5b0 11.3 landed
- 9e138a401d19 12.0 landed
- 904fce2a7695 9.6.13 landed
- 8ec638e69c01 10.8 landed