Re: Fixing cache pollution in the Kerberos test suite
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jacob Champion <pchampion@vmware.com>
Cc: "sfrost@snowman.net" <sfrost@snowman.net>,
"pgsql-hackers@lists.postgresql.org"
<pgsql-hackers@lists.postgresql.org>
Date: 2021-01-25T19:04:34Z
Lists: pgsql-hackers
Jacob Champion <pchampion@vmware.com> writes: > On Mon, 2021-01-25 at 13:49 -0500, Tom Lane wrote: >> Yeah, changing global state is just awful. However, I don't >> actually see any change here (RHEL8): > Interesting. I'm running Ubuntu 20.04: Hmm. I'll poke harder. >> Also, why are you only setting the ENV variable within narrow parts >> of the test script? I'd be inclined to enforce it throughout. > I considered it and decided I didn't want to pollute the server's > environment with it, since the server shouldn't need the client cache. True, but if it did try to access the cache, accessing the user's normal cache would be strictly worse than accessing the test cache. regards, tom lane
Commits
-
Don't clobber the calling user's credentials cache in Kerberos test.
- b8894a3661d4 11.11 landed
- 881933f19422 14.0 landed
- 820aa9ef4c35 12.6 landed
- 366d302d14f7 13.2 landed