Re: 001_password.pl fails with --without-readline

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Soumya S Murali <soumyamurali.work@gmail.com>
Cc: Oleg Tselebrovskiy <o.tselebrovskiy@postgrespro.ru>, pgsql-hackers@postgresql.org
Date: 2026-01-17T00:19:38Z
Lists: pgsql-hackers

Attachments

I wrote:
> There are various ways that could be done, but what I propose in the
> attached v3 is to break the banner into two psql variables, like so:
> 	\set part1 something
> 	\set part2 else
> 	\echo :part1 :part2
> Then, if we match for "something else", there is no possibility
> whatsoever that that will match echoed commands, only the real
> output of the \echo.

On second thought, that's far more complicated than necessary.
It should be sufficient to insert quote marks in the echo commands.

			regards, tom lane

Commits

  1. Make psql/t/030_pager.pl more robust.

  2. Improve guards against false regex matches in BackgroundPsql.pm.

  3. Fix unsafe pushdown of quals referencing grouping Vars

  4. tests: BackgroundPsql: Fix potential for lost errors on windows