Horton

Re: Move SLRU_PAGES_PER_SEGMENT to pg_config_manual.h

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Álvaro Herrera <alvherre@kurilemu.de>, Daniel Gustafsson <daniel@yesql.se>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Maxim Orlov <orlovmg@gmail.com>, Daniil Davydov <3danissimo@gmail.com>
Date: 2025-11-10T17:36:14Z
Lists: pgsql-hackers 
Heikki Linnakangas <hlinnaka@iki.fi> writes:
> On 10/11/2025 17:16, Tom Lane wrote:
>> I think the number this should have bumped is PG_CONTROL_VERSION
>> (thanks to the new field therein).  Bumping CATALOG_VERSION_NO
>> seems quite beside the point.

> Ah thanks, I forgot we have that as a separate version number. I'll go 
> bump that now. (I will not try to revert the CATALOG_VERSION_NO change, 
> that would be very confusing.)

Agreed, undoing it would accomplish nothing good.

			regards, tom lane

Commits

  1. Add warning to pg_controldata on PG_CONTROL_VERSION mismatch

  2. Add pg_resetwal and pg_controldata support for new control file field

  3. Bump PG_CONTROL_VERSION for commit 3e0ae46d90

  4. Move SLRU_PAGES_PER_SEGMENT to pg_config_manual.h