Horton
Menu

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove useless check for negative result of ip_addrsize().

  1. BUG #18889: /src/backend/utils/adt/network.c condition is always false

    PG Bug reporting form <noreply@postgresql.org> — 2025-04-10T16:41:51Z

    The following bug has been logged on the website:

Bug reference:      18889
Logged by:          Daniel Elishakov
Email address:      dan-eli@mail.ru
PostgreSQL version: 17.4
Operating system:   Ubuntu 20.04
Description:        

On line 282 there is a check of nb < 0, which is always false, so i think it
is better to be replaced with 'Assert(nb > 0);'

  2. Re: BUG #18889: /src/backend/utils/adt/network.c condition is always false

    Tom Lane <tgl@sss.pgh.pa.us> — 2025-04-10T18:19:52Z

    PG Bug reporting form <noreply@postgresql.org> writes:
> On line 282 there is a check of nb < 0, which is always false, so i think it
> is better to be replaced with 'Assert(nb > 0);'

This one I do agree with getting rid of --- in fact, I don't
even see a need for an Assert.  Done at f27eb0325.

			regards, tom lane