Re: Reword messages using "as" instead of "because"

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Amit Kapila <amit.kapila16@gmail.com>

Cc: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>

Date: 2025-09-18T12:11:33Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Improve few errdetail messages introduced in commit 0d48d393d46.
- 8aac5923a361 19 (unreleased) landed
Resume conflict-relevant data retention automatically.
- 0d48d393d465 19 (unreleased) cited

Amit Kapila <amit.kapila16@gmail.com> writes:
> Yeah, this sounds clear but shall we consider using
> max_retention_duration like: "Retention is re-enabled because the
> apply process has caught up with the publisher within the configured
> max_retention_duration.". We can have a single message if we don't
> want to specify the value of max_retention_duration or simply skip
> adding max_retention_duration.

That wording sounds good to me.  I think you could leave out
the mention of max_retention_duration, but I won't fight if
people prefer to include it.

			regards, tom lane