Horton

Re: PSA: we lack TAP test coverage on NetBSD and OpenBSD

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Mikael Kjellström <mikael.kjellstrom@mksoft.nu>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2019-01-17T23:11:20Z
Lists: pgsql-hackers 
=?UTF-8?Q?Mikael_Kjellstr=c3=b6m?= <mikael.kjellstrom@mksoft.nu> writes:
>> But it looks like in NetBSD the options are called:

Sorry about that, I copied-and-pasted from the openbsd machine I was
looking at without remembering that netbsd is just a shade different.

> but the OpenBSD machine went further and now fails on:
> pgbenchCheck instead.
> Is that the failure you expected to get?

Yup, sure is.  Thanks!

			regards, tom lane

Commits

  1. Fix portability problem in pgbench.

  2. Avoid assuming that we know the spelling of getopt_long's error messages.