Horton

Thread

Commits

  1. Doc: specify aclitem syntax more clearly.

  1. Documentation does not describes format for access privileges: =Tc/user

    The Post Office <noreply@postgresql.org> — 2023-12-22T16:06:09Z

    The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/16/ddl-priv.html
Description:

Hello.
The page https://www.postgresql.org/docs/current/ddl-priv.html does not
describe what =Tc/user means. Also I did not find a link to appropriate page
which describes this.
Specifically I do not understand how 'user=Tc/user' differs from
'=Tc/user'.

It would be nice if documentation will be extended.
Thank you.

  2. Re: Documentation does not describes format for access privileges: =Tc/user

    David G. Johnston <david.g.johnston@gmail.com> — 2023-12-24T15:12:58Z

    On Friday, December 22, 2023, PG Doc comments form <noreply@postgresql.org>
wrote:

> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/16/ddl-priv.html
> Description:
>
> Hello.
> The page https://www.postgresql.org/docs/current/ddl-priv.html does not
> describe what =Tc/user means. Also I did not find a link to appropriate
> page
> which describes this.
> Specifically I do not understand how 'user=Tc/user' differs from
> '=Tc/user'.
>
> It would be nice if documentation will be extended.
>
>
The paragraph immediately following table 5.2 describes all of this.

David J.

  3. Re: Documentation does not describes format for access privileges: =Tc/user

    Eugen Konkov <konkove@gmail.com> — 2023-12-25T17:48:31Z

    No, it does not. If you refer to `An empty grantee field in an aclitem
stands for PUBLIC.` then "grantee field" was never described. What is
this?

It would be very clear if it was described in this way:
The access privileges has the following format: "grantee=privileges/who grants".


On Sun, Dec 24, 2023 at 10:13 AM David G. Johnston
<david.g.johnston@gmail.com> wrote:
>
> On Friday, December 22, 2023, PG Doc comments form <noreply@postgresql.org> wrote:
>>
>> The following documentation comment has been logged on the website:
>>
>> Page: https://www.postgresql.org/docs/16/ddl-priv.html
>> Description:
>>
>> Hello.
>> The page https://www.postgresql.org/docs/current/ddl-priv.html does not
>> describe what =Tc/user means. Also I did not find a link to appropriate page
>> which describes this.
>> Specifically I do not understand how 'user=Tc/user' differs from
>> '=Tc/user'.
>>
>> It would be nice if documentation will be extended.
>>
>
> The paragraph immediately following table 5.2 describes all of this.
>
> David J.
>

  4. Re: Documentation does not describes format for access privileges: =Tc/user

    David G. Johnston <david.g.johnston@gmail.com> — 2023-12-25T18:02:57Z

    On Monday, December 25, 2023, Eugen Konkov <konkove@gmail.com> wrote:

> No, it does not. If you refer to `An empty grantee field in an aclitem
> stands for PUBLIC.` then "grantee field" was never described. What is
> this?
>
> It would be very clear if it was described in this way:
> The access privileges has the following format: "grantee=privileges/who
> grants".
>
>
Yes, it requires a bit of mental gymnastics to read.  The description says
Calvin is the role being granted the privileges which makes that the
grantee and Calvin is listed before the equal sign in the reference.

“Who grants” is the “grantor”.

I’ll accept that this can be improved but aside from a dictionary
definition of grantee, which we don’t usually do, everything is shown.

David J.

  5. Re: Documentation does not describes format for access privileges: =Tc/user

    David G. Johnston <david.g.johnston@gmail.com> — 2023-12-25T18:16:33Z

    On Monday, December 25, 2023, David G. Johnston <david.g.johnston@gmail.com>
wrote:

> On Monday, December 25, 2023, Eugen Konkov <konkove@gmail.com> wrote:
>
>> No, it does not. If you refer to `An empty grantee field in an aclitem
>> stands for PUBLIC.` then "grantee field" was never described. What is
>> this?
>>
>> It would be very clear if it was described in this way:
>> The access privileges has the following format: "grantee=privileges/who
>> grants".
>>
>>
> Yes, it requires a bit of mental gymnastics to read.  The description says
> Calvin is the role being granted the privileges which makes that the
> grantee and Calvin is listed before the equal sign in the reference.
>
> “Who grants” is the “grantor”.
>
> I’ll accept that this can be improved but aside from a dictionary
> definition of grantee, which we don’t usually do, everything is shown.
>

We probably should write the syntax like we do everywhere else:

[grantee]={privilege[*]}[…]/grantor

Then define the placeholders in the subsequent paragraph.

David J.

  6. Re: Documentation does not describes format for access privileges: =Tc/user

    Tom Lane <tgl@sss.pgh.pa.us> — 2023-12-25T18:31:11Z

    "David G. Johnston" <david.g.johnston@gmail.com> writes:
> We probably should write the syntax like we do everywhere else:
> [grantee]={privilege[*]}[…]/grantor
> Then define the placeholders in the subsequent paragraph.

Seems reasonable.  About like this?

			regards, tom lane