Horton

Re: Failure in contrib test _int on loach

Heikki Linnakangas <hlinnaka@iki.fi>

View thread View on postgr.es
From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org, Teodor Sigaev <teodor@sigaev.ru>
Date: 2019-05-02T07:37:29Z
Lists: pgsql-hackers 
(resending, previous attempt didn't make it to pgsql-hackers)

On 29/04/2019 16:16, Anastasia Lubennikova wrote:
> In previous emails, I have sent two patches with test and bugfix (see
> attached).
> After Heikki shared his concerns, I've rechecked the algorithm and
> haven't found any potential error.
> So, if other hackers are agreed with my reasoning, the suggested fix is
> sufficient and can be committed.

I still believe there is a problem with grandparent splits with this. 
I'll try to construct a test case later this week, unless you manage to 
create one before that.

- Heikki

Commits

  1. Detect internal GiST page splits correctly during index build.

  2. Generate less WAL during GiST, GIN and SP-GiST index build.