Horton

Re: Underscores in numeric literals

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>, Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-02-02T22:39:59Z
Lists: pgsql-hackers 
On 31.01.23 17:09, Dean Rasheed wrote:
> On Tue, 31 Jan 2023 at 15:28, Peter Eisentraut
> <peter.eisentraut@enterprisedb.com> wrote:
>>
>> Did you have any thoughts about what to do with the float types?  I
>> guess we could handle those in a separate patch?
>>
> 
> I was assuming that we'd do nothing for float types, because anything
> we did would necessarily impact their performance.

Yeah, as long as we are using strtof() and strtod() we should just leave 
it alone.  If we have break that open and hand-code something, we can 
reconsider it.

So I think you could go ahead with committing your patch and we can 
consider this topic done for now.

Commits

  1. Allow underscores in integer and numeric constants.