BUG #18850: REDUNDANT_COMPARISON.ALWAYS_FALSE Redundant comparison

PG Bug reporting form <noreply@postgresql.org>

From: PG Bug reporting form <noreply@postgresql.org>
To: pgsql-bugs@lists.postgresql.org
Cc: pm91.arapov@gmail.com
Date: 2025-03-14T09:16:06Z
Lists: pgsql-bugs
The following bug has been logged on the website:

Bug reference:      18850
Logged by:          Nikita
Email address:      pm91.arapov@gmail.com
PostgreSQL version: 16.6
Operating system:   ubuntu 20.04
Description:        

REDUNDANT_COMPARISON.ALWAYS_FALSE Redundant comparison

diff --git a/src/backend/commands/operatorcmds.c
b/src/backend/commands/operatorcmds.c
--- a/src/backend/commands/operatorcmds.c	(revision
a49ac80219c6f28c3cf3973f797de637329952da)
+++ b/src/backend/commands/operatorcmds.c	(date 1740387217614)
@@ -209,11 +209,6 @@
 		typeId[0] = typeId2;
 		nargs = 1;
 	}
-	else if (!OidIsValid(typeId2))
-	{
-		typeId[0] = typeId1;
-		nargs = 1;
-	}
 	else
 	{
 		typeId[0] = typeId1;

I suggest the following patch fixing this issue