Horton
Menu

Re: Functional dependencies and GROUP BY

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Peter Eisentraut <peter_e@gmx.net>, Alex Hunsaker <badalex@gmail.com>, pgsql-hackers@postgresql.org
Date: 2010-09-05T15:35:45Z
Lists: pgsql-hackers 
Dean Rasheed <dean.a.rasheed@gmail.com> writes:
> On 5 September 2010 16:15, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I don't recall having thought about it one way or the other. What did
>> the check look like?

> Well originally it was searching indexes rather than constraints, and
> funcdeps_check_pk() included the following check:

> if (!indexStruct->indisprimary || !indexStruct->indimmediate)
> 	continue;

> Now its looping over pg_constraint entries, so I guess anything wtih
> con->condeferrable == true should be ignored.

Seems reasonable, will fix.  Thanks for the report!

			regards, tom lane