Re: Add PortalDrop in exec_execute_message
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Yura Sokolov <y.sokolov@postgrespro.ru>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
pgsql-hackers@lists.postgresql.org
Date: 2021-06-11T13:38:25Z
Lists: pgsql-hackers
Yura Sokolov <y.sokolov@postgrespro.ru> writes: > This makes me think, Close message were intended to be used > but simply forgotten when libpq patch were made. > Tom, could I be right? You could argue all day about what the intentions were nearly twenty years ago. But the facts on the ground are that we don't issue Close in those places, and changing it now would be a de facto protocol change for applications. So I'm a hard -1 on these proposals. (Alvaro's proposed change isn't a protocol break, since pipeline mode hasn't shipped yet. It's trying to make some brand new code act more like old code, which seems like a fine idea.) I think that the actual problem here has been resolved in commit bb4aed46a. Perhaps we should reconsider my decision not to back-patch that. Unlike a protocol change, that one could possibly be sane to back-patch. I didn't think it was worth the trouble and risk, but maybe there's a case for it. regards, tom lane
Commits
-
Add 'Portal Close' message to pipelined PQsendQuery()
- 4efcf47053ea 14.0 landed
-
Shut down EvalPlanQual machinery when LockRows node reaches the end.
- bb4aed46a5ae 14.0 landed
-
Update libpq to make new features of FE/BE protocol available to
- efc3a25bb02a 7.4.1 cited
-
Extended query protocol: parse, bind, execute, describe FE/BE messages.
- 16503e6fa4a1 7.4.1 cited