Horton

Re: Incorrect allocation handling for cryptohash functions with OpenSSL

Heikki Linnakangas <hlinnaka@iki.fi>

View thread View on postgr.es
From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-01-06T13:27:03Z
Lists: pgsql-hackers 
On 06/01/2021 13:42, Michael Paquier wrote:
> On Sat, Dec 19, 2020 at 03:13:50PM +0900, Michael Paquier wrote:
>> At the same time, I have taken care of your comment from upthread to
>> return a failure if the caller passes NULL for the context, and
>> adjusted some comments.  What do you think of the attached?
> 
> I have looked again at this thread with a fresher mind and I did not
> see a problem with the previous patch, except some indentation
> issues.  So if there are no objections, I'd like to commit the
> attached.

Looks fine to me.

- Heikki

Commits

  1. Fix and simplify some code related to cryptohashes

  2. Fix allocation logic of cryptohash context data with OpenSSL