Re: PGXS: REGRESS_OPTS=--load-language=plpgsql

David E. Wheeler <david@kineticode.com>

From: "David E. Wheeler" <david@kineticode.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>, David Fetter <david@fetter.org>, Euler Taveira de Oliveira <euler@timbira.com>, PG Hackers <pgsql-hackers@postgresql.org>
Date: 2010-02-19T07:34:26Z
Lists: pgsql-hackers
On Feb 18, 2010, at 8:38 PM, Tom Lane wrote:

>> The regression test in the core is targeting only its version,
>> but some external projects have version-independent tests.
> 
> I think it's more like "are under the fond illusion that their tests are
> version-independent".  Are we going to back out the next incompatible
> change we choose to make as soon as somebody notices that it breaks a
> third-party test case?  I don't think so.  Let me point out that
> choosing to install plpgsql by default has already broken "--single"
> restore of practically every pg_dump out there.  Nobody batted an eye
> about that.  Why are we suddenly so concerned about its effects on
> unnamed test suites?

Because it's a lot easier for `pg_regress --load-language=plpgsql` to mean "ensure the language is installed" than it is for 3rd-party test suites to detect what version they're being installed against.

Really, all that has to happen is pg_regress in 8.5a4+ needs to just ignore `--load-language=plpgsql`. That's it.

Best,

David